Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more PHPMD Rules #95

Merged
merged 6 commits into from
Jul 24, 2024
Merged

Add more PHPMD Rules #95

merged 6 commits into from
Jul 24, 2024

Conversation

phily245
Copy link
Contributor

@phily245 phily245 commented Jul 24, 2024

Adds the following rules:

  • Controversial
  • Naming
  • Unused code

#86

phily245 added 6 commits July 24, 2024 11:16
This should ensure we have just about the right amount of context in
names
This keeps unused code out of the repo
This will keep the code tidier, easier to read, less decoupled and more
standardised
This shows the "why" behind the exclusion
This is a stub of dependencies, which we have no control over
This broke parsing, so I used the "unused formal parameter"
@phily245 phily245 merged commit 1c07521 into v2.0 Jul 24, 2024
6 checks passed
@phily245 phily245 deleted the add-phpmd branch July 24, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant